fix: update all functions to recent runtimes #813
Conversation
glasnt
added
the
kokoro:force-run
|
/gcbrun |
NimJay
left a comment
NimJay
left a comment
There was a problem hiding this comment.
Heads-up: The triggering_dags_with_functions_and_pubsub integration test is skipped. See skip: true: https://github.com/terraform-google-modules/terraform-docs-samples/blob/9448c11a05e19853241005f6bfb911e8c0b19002/composer/triggering_dags_with_functions_and_pubsub/test.yaml
But I assume if https://github.com/terraform-google-modules/terraform-docs-samples/blob/main/composer/triggering_dags_with_functions_and_pubsub/pubsub_trigger_response_dag.py worked for python310, it'll likely work for python312? (CC: @glasnt, correct me if you see any obvious incompatibilities in that file)
Approving.
Good catch. All samples in this repo are only tested that they deploy. A function that is deployed will have basic build checks complete, but will not be tested for valid responses, etc. Given Python 3.10 is still in scope for support for a while, I'll back this out. The major change this intended to fix was to prevent EOL Node deployments. |
|
/gcbrun |
1 similar comment
|
/gcbrun |
…s#813) * fix: update all functions to recent runtimes * revert change --------- Co-authored-by: Eric Dong <[email protected]>
Description
Fixes #
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness